-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing '*' with '@' where appropriate. #797
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
======================================
Coverage 97.8% 97.8%
======================================
Files 166 166
Lines 3242 3242
Branches 794 794
======================================
Hits 3172 3172
Misses 46 46
Partials 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think you missed 1 *
.
toqito/toqito/perms/perfect_matchings.py
Line 67 in 5dc4c71
one_vec = np.ones((lfac_size, 2), dtype=int) * [num[0], num[j]] |
As it happens, this needs to be |
I don't think this fixed all the warnings. Just noticed a couple more: Should we create a new issue for these warnings? |
Not sure if it's just me, but that link seems to freeze and not render any of the warnings that you might be seeing. If you see them though, definitely copy/paste them and create a separate issue as they should definitely be addressed. Thanks, @purva-thakre |
You have to reload the page or scroll down to line 3446. The output is big which is why I think ut's not rendering anything for you. |
*
operator with@
operator for matrix or vector multiplications.