soap client describe() resolves namespace cross references between schema #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herom
reviewed
Jul 20, 2018
lib/wsdl.js
Outdated
| @@ -116,6 +117,12 @@ var Element = function(nsName, attrs, options) { | |||
| } | |||
| } | |||
| } | |||
| for (var schemaKey in schemaAttrs) { | |||
| var schemaMatch = /^xmlns:?(.*)$/.exec(schemaKey); | |||
| if (schemaMatch && schemaMatch[1] && schemaMatch) { | |||
There was a problem hiding this comment.
did you really want to check for schemaMatch twice here? 😄
herom
reviewed
Jul 20, 2018
| @@ -855,7 +862,9 @@ ElementElement.prototype.description = function(definitions, xmlns) { | |||
| if (type) { | |||
| type = splitQName(type); | |||
| var typeName = type.name, | |||
| ns = xmlns && xmlns[type.prefix] || definitions.xmlns[type.prefix], | |||
| ns = xmlns && xmlns[type.prefix] || | |||
| (definitions.xmlns[type.prefix] !== undefined && this.schemaXmlns[type.prefix]) || | |||
There was a problem hiding this comment.
when checking for !== undefined explicitly, we are aware that null would pass - is this intentional?
There was a problem hiding this comment.
Here I checked the presence or absence of the property, not its value. So yes, it was intentional to check only for undefined.
There was a problem hiding this comment.
Anyway, I could change definitions.xmlns[type.prefix] !== undefined into definitions.xmlns[type.prefix]
There was a problem hiding this comment.
I checked the presence or absence of the property
good catch, I didn' t think of that... 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds support to cross references in namespaces between types from different schema.