Allow a fixed file path for local includes #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetSuite wsdl uses relative paths but when downloaded NS flattens all files in a single directory and fails to load.
jsdevel
requested changes
Aug 27, 2019
| @@ -1170,7 +1170,12 @@ export class WSDL { | |||
|
|
|||
| let includePath: string; | |||
| if (!/^https?:/i.test(this.uri) && !/^https?:/i.test(include.location)) { | |||
| includePath = path.resolve(path.dirname(this.uri), include.location); | |||
| const isFixed = (this.options.wsdl_options !== undefined && this.options.wsdl_options.hasOwnProperty('fixedPath')) ? this.options.wsdl_options.fixedPath : false; | |||
There was a problem hiding this comment.
add this option to the readme please, with an explanation.
added 2 commits
August 28, 2019 17:11
NetSuite wsdl uses relative paths but when downloaded NS flattens all files in a single directory and fails to load.
|
Modified readme.md |
|
i can squash. thanks! |
Danail-Irinkov
pushed a commit
to Danail-Irinkov/node-soap
that referenced
this pull request
Jan 19, 2020
* Allow a fixed file path for local includes NetSuite wsdl uses relative paths but when downloaded NS flattens all files in a single directory and fails to load. * Allow a fixed file path for local includes NetSuite wsdl uses relative paths but when downloaded NS flattens all files in a single directory and fails to load.
This was referenced Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetSuite wsdl uses relative paths but when downloaded NS flattens all files in a single directory and fails to load.
This option loads all the files from the directory as provided by NetSuite zip file.
Using with node-suitetalk
https://github.com/felipechang/node-suitetalk