Allows SchemaElement instance to use import namespace as targetNamesp…#1095
Allows SchemaElement instance to use import namespace as targetNamesp…#1095ndeniche wants to merge 2 commits intovpulim:masterfrom
Conversation
…ace when the attribute is not set. ### Allows SchemaElement instance to use import namespace as targetNamespace when the attribute is not set. Prevents the following error message when schema elements do not include targetNamespace attribute: > Target-Namespace "undefined" already in use by another Schema!
|
@ndeniche please fix the build and bring coverage back up. |
|
Same as the other added feature. All of the new code is covered. Should I improve coverage by adding tests to other features? |
|
@ndeniche if coverage drops on this build, that means that added code has decreased it right? |
|
|
|
Was the test coverage on this resolved? Can it be merged soon? |
|
@barboni it could be the case that this fix now makes other code unreachable: code who's past assumptions are no longer valid with this fix. can you look into it? |
|
I have the same problem as ndeniche and I don't have control over the WSDL. A fix would be appreciated. |
|
as long as coverage doesn't dip, we can merge the fix. |
|
It would be kindly appreciated ! |
|
well, someone has to add a test. feel free to plagaraize this in a new pr with a test |
|
@w666 -- it seems this just needs a rebase for the recent checks to run |
|
@w666 -- this PR can now simply be closed, since its superseding PR got merged. Thank you. |
|
Closing |
8 participants
Allows SchemaElement instance to use import namespace as targetNamespace when the attribute is not set.
Prevents the following error message when schema elements do not include
targetNamespaceattribute:If
targetNamespaceis declared by an import is used in a different schema, it overrides the value for the targetNamespace key.