Fix min/maxOccurs parsing and handling

[kouak]

Consider this XSD :

                <xs:element name="DummyList" minOccurs="1" maxOccurs="10">
                    <xs:complexType>
                        <xs:sequence>
                            <xs:element name="DummyFirst" type="xs:string" />    
                            <xs:element name="DummySecond" type="xs:string" />
                        </xs:sequence>
                    </xs:complexType>
                </xs:element>

We should expect node-soap to deserialize DummyList as an array regardless of the number of elements in the document.

Consider this response :

<Parent>
    <DummyList>
        <DummyFirst>foo</DummyFirst>
        <DummySecond>foo</DummySecond>
    </DummyList>
</Parent>

Before this PR, this would be transformed to :

{
  "DummyList": {
    "DummyFirst": "foo",
    "DummySecond": "foo"
  }
}

After this PR :

{
  "DummyList": [
    {
      "DummyFirst": "foo",
      "DummySecond": "foo"
    }
  ],
}

We noticed this regression upgrading our app from node-soap 0.26.0 to 0.30.0. We pinpointed its introduction between 0.26 and 0.27, possibly during the typescript rewrite.

Also the former typings were wrong: AFAIK, sax parses minOccurs and maxOccurs attributes to strings making this code not perform correctly unless maxOccurs was set to "unbounded".

[coveralls]

Coverage decreased (-0.5%) to 94.538% when pulling 23271a2 on kouak:fix-min-max-occurs into af93a6f on vpulim:master.

[jsdevel]

please fix the build

[kouak]

Coveralls seems to be the issue for the failed builds : https://travis-ci.org/vpulim/node-soap/jobs/622742785#L1622-L1625

Not sure how I can fix that though.

[kouak]

I ran the pipeline again by force pushing to the source branch.

Travis CI is all good now. The previous error was probably just a fluke.

[jsdevel]

please revert package-lock.json. also, i can't tell what was changed in the src file because the entire file was formatted. please revert space changes.

[kouak]

My bad, the PR should be reviewable now.

[jsdevel]

thanks @kouak ! looks like coverage decreased. can you cover the other cases that you're adding?

[kouak]

Yeah I had a look into that but I'm at lost here ...

If I read the following image correctly, coveralls reports a decreased coverage in src/ and src/wsdl/ but an increase in both src/wsdl/index.ts and src/wsdl/element.ts ?

Also, it looks like all the added lines are covered if I read this report correctly.

[jsdevel]

thanks @kouak !

[jsdevel]

@kouak could it be that we now have dead code elsewhere?

[kouak]

@jsdevel: As far as I'm aware I'd say no.

Could it be possible to prepare a new release including this fix ? That would greatly help our project. Thanks !

[jsdevel]

soon @kouak