WSSecurity Protocol with user/pass token element. #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlafurTorfi
changed the title
jsdevel
requested changes
May 23, 2022
|
please fix the build |
jsdevel
requested changes
May 30, 2022
reverting minor version bump, as requested by reviewer.
|
@OlafurTorfi please fix the build |
|
The merge conflict has been resolved. |
|
@OlafurTorfi please fix the build |
w666
approved these changes
May 1, 2024
|
I resolved conflict and seemed like it works. Wondering if @jsdevel wants to review it again? |
|
No objections on this PR, tests passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I pulled the package, and the tests were failing out of the box. So I just made some minor hacks to get the tests running.
Then I updated all but two of the packages (the major versions of formidable and strip-bom required more changes than fixing the import and adding some types. So I left those.
Then I added a new security protocol, WSSecurityCertWithToken. Is basically the same as WSSecurityCert, except that it takes in a username and password as well. Which we need here in iceland.
I have used this WSSecurityCertWithToken protocol implementation in production, and can confirm that it works.