Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix including xsd from another xsd while using inline xmlns #1202

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

e6c31d
Copy link
Contributor

@e6c31d e6c31d commented Nov 16, 2022

No description provided.

@jsdevel
Copy link
Collaborator

jsdevel commented Dec 9, 2022

@e6c31d plz get the build to pass

@e6c31d e6c31d force-pushed the handle_inline_xmlns branch from 770ff88 to bc8bbdc Compare December 11, 2022 06:00
@e6c31d
Copy link
Contributor Author

e6c31d commented Dec 11, 2022

@jsdevel I don't think the build failure is related to this PR. It builds successfully for me on Node.js 14 and 16, but not on 18. The build also fails on the master branch on Node.js 18.

@e6c31d
Copy link
Contributor Author

e6c31d commented Dec 11, 2022

@jsdevel I created another PR to fix the build on Node.js 18: #1206

@w666 w666 force-pushed the handle_inline_xmlns branch from bc8bbdc to 6f97cf5 Compare July 17, 2024 07:38
@w666
Copy link
Collaborator

w666 commented Jul 17, 2024

Hi @e6c31d,

I rebased you branch to check if it still works, I recently released new version with some major changes.

I will merge it and include into next release.

@w666 w666 self-requested a review July 17, 2024 07:41
@w666 w666 merged commit 579ffc0 into vpulim:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants