-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookup definitions in child element first #958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lfantone thanks a lot for your contribution 👍 please add a |
crash7
force-pushed
the
fix/child-xmlns
branch
from
October 30, 2017 12:44
e1f90de
to
201e4cf
Compare
Awesome job @crash7 ! I love seeing all that green and no red! That's what we're after! |
@jsdevel excellent 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this case where the
xmlns
definition is added as axmlns:{prefix}
attribute to the element and the wsdl library wasn't able to find the Schema Object because It only looks into the global definitions.Example of a not working xml schema:
This PR solves the issue describe above by looking the prefix in the child xmlns with a fallback to the
this.definitions.xmlns
.I'm not sure if this this needs an specific unit test to being added, if so please let me know I'll try to add it.