Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add rawRequest to callback arguments #992

Merged
merged 1 commit into from
Jan 15, 2018
Merged

feat(client): add rawRequest to callback arguments #992

merged 1 commit into from
Jan 15, 2018

Conversation

matt-forster
Copy link
Contributor

Use case: Allows clients who send requests asynchronously to accurately log the requests they are making.

Adds the XML raw request as an argument to the client callback. This allows correct tracking of the requests, as requests made asynchronously on the same client will overwrite the client.lastRequest attribute.

I added a test to the headers describe block as that is where it seemed similar code was being tested.

@coveralls
Copy link

coveralls commented Dec 14, 2017

Coverage Status

Coverage remained the same at 93.648% when pulling f4f025d on autovance:master into f8f5aef on vpulim:master.

@coveralls
Copy link

coveralls commented Dec 14, 2017

Coverage Status

Coverage remained the same at 93.648% when pulling 242f667 on autovance:master into f8f5aef on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Jan 13, 2018

@herom what are your thoughs?

@herom
Copy link
Contributor

herom commented Jan 15, 2018

@jsdevel @forstermatth This seems like a really useful addition to our library - thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants