lazy loading through dom-if #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I rebased your branch on the master in order to keep it in sync with the latest deliveries |
vpusher
reviewed
Mar 1, 2017
paper-tree-node.html
Outdated
| </li> | ||
| </template> | ||
| </ul> | ||
| <template is="dom-if" if$="{{data.open}}"> |
There was a problem hiding this comment.
why are you doing an attribute binding here instead of a simple property binding ?
There was a problem hiding this comment.
I hadn't noticed I had, sorry
|
I've changed the if attribute |
|
@benbenbenbenbenben great ! Merging. I will release the new version asap. |
|
@benbenbenbenbenben Released in v1.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.