Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 preview #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

andreaskalin
Copy link

Polymer 2.0 hybrid element, intended for a 2.0-preview branch.

Tested on Ubuntu 16.04, on Chrome 58 and FF 53.

  • 'polymer build' is currently broken, see Import should be paper-material-styles for 2.0 preview PolymerElements/paper-button#162
  • Lazy loading is now supported by the component; the --paper-tree-toggle-theme is however retained for 1.0 compat (untested).
  • Replaced paper-menu with paper-listbox, since paper-menu does not yet have a 2.0-preview branch.
  • Added direct dep to web-animations-js to get rid of "Uncaught ReferenceError: KeyframeEffect is not defined".

Replaced paper-menu with paper-listbox, since paper-menu does not yet have a 2.0-preview branch.
See PolymerElements/paper-button#162 for problems with 'polymer build'.
TODO: Lazy loading demo is currently broken.
Moved lazy loading from demo to the component.
I didn't get updateStyles([...]) to work with css mixins (--paper-tree-toggle-theme) and at-rules (@Keyframes) are scoped. Anyway, lazy loading is a nice feature to support.
@warpech
Copy link

warpech commented Oct 9, 2017

@vpusher thanks for a great custom element. Could this PR be accepted to make it work with Polymer 2.0?

@warpech
Copy link

warpech commented Jul 25, 2018

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants