-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support animation property #1
Conversation
@skinnyjames Thanks alot for taking your time. I'll review and merge the PR soon. Cheers 🎉 |
@vrajroham no problem! I'll will probably be using this route to fit my needs, if you wanted to take a look at it and were interested, I'd be happy to rework or make a PR. https://github.com/skinnyjames/vue-circle-progress/tree/idea |
@skinnyjames Thanks for your contribution. You are the first contributor to this library. Cheers 🎉 |
Awesome! I might make some performance optimizations, as I'm not sure how properties are optimized in vue components, but happy to contribute! |
Just released new version to npm with your contribution! @skinnyjames If you are interested I can add you as contributor, so you can freely work around without my intervention. Let me know! EditI mean to say collaborator. |
Sure! I can work on docs, issues, or optimizations. |
Hope you would have got invitation link. 👍 If you are interested in VueJS stuff and libraries then, below are some libraries where active development is going on and you can learn much more things there. https://github.com/rowanwins/vue-dropzone |
Great, I'll check it out |
This PR supports the animation property in https://github.com/kottenator/jquery-circle-progress.
It also emits a vue event on the circle's initialization.