Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support animation property #1

Merged
merged 5 commits into from
Oct 7, 2017
Merged

Support animation property #1

merged 5 commits into from
Oct 7, 2017

Conversation

skinnyjames
Copy link
Collaborator

This PR supports the animation property in https://github.com/kottenator/jquery-circle-progress.
It also emits a vue event on the circle's initialization.

@vrajroham
Copy link
Owner

@skinnyjames Thanks alot for taking your time. I'll review and merge the PR soon.

Cheers 🎉

@skinnyjames
Copy link
Collaborator Author

@vrajroham no problem!
I actually reworked the format of how the boxes are made (using a slot instead of inner-text) in order to show the percentage and other html at the same time.

I'll will probably be using this route to fit my needs, if you wanted to take a look at it and were interested, I'd be happy to rework or make a PR.

https://github.com/skinnyjames/vue-circle-progress/tree/idea

@vrajroham vrajroham merged commit 3049b72 into vrajroham:master Oct 7, 2017
@vrajroham
Copy link
Owner

@skinnyjames Thanks for your contribution. You are the first contributor to this library.
Also I pulled and merged your slot feature in repo. See #2

Cheers 🎉

@skinnyjames
Copy link
Collaborator Author

Awesome! I might make some performance optimizations, as I'm not sure how properties are optimized in vue components, but happy to contribute!

@vrajroham
Copy link
Owner

vrajroham commented Oct 7, 2017

Just released new version to npm with your contribution!

@skinnyjames If you are interested I can add you as contributor, so you can freely work around without my intervention. Let me know!


Edit

I mean to say collaborator.

@skinnyjames
Copy link
Collaborator Author

Sure! I can work on docs, issues, or optimizations.

@vrajroham
Copy link
Owner

Hope you would have got invitation link. 👍

If you are interested in VueJS stuff and libraries then, below are some libraries where active development is going on and you can learn much more things there.


https://github.com/rowanwins/vue-dropzone
https://github.com/vrajroham/vue-simple-lightbox

@skinnyjames
Copy link
Collaborator Author

Great, I'll check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants