Implementing new methods for scrolling #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue using your great module. I needed to use and mock scroll methods in order to have a good coverage, so I implemented a few things :
When using the
search
method ifparams['scroll']
is provided, then you'll have aresult['_scroll_id']
value in the response, that you'll be able to use further on to get next set of hits.When using the
scroll
parameter, hits count will be limited either to10
which is elasticsearch default size, either toparams['size']
if provided. Next hits set will be of the same size until no more hits are available for the current query.New code is unit tested, and existing tests are passing.
Please, give me any feedback if you are forseeing any issue with this ✌️