Allow ignoring of missing documents (404) for get and delete #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This PR adds functionality to the
get
anddelete
method adhere to the ignore parameter in case the document is not found. Previously aNotFoundError
was raised. Now we check if we need to ignore 404 errors and if so, simply return an object where thefound
flag is False.Documentation: https://elasticsearch-py.readthedocs.io/en/latest/api.html#ignore