Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity2019.1対応 #237

Closed
hiroj opened this issue Apr 19, 2019 · 7 comments
Closed

Unity2019.1対応 #237

hiroj opened this issue Apr 19, 2019 · 7 comments
Milestone

Comments

@hiroj
Copy link
Contributor

hiroj commented Apr 19, 2019

  • MToonの表示に不具合あり
  • その他不具合を調査中
@hiroj hiroj added this to the v0.52.0 milestone Apr 19, 2019
@hiroj hiroj added the common label Apr 19, 2019
@SetoKaiba
Copy link

I use frame debugger and find that the keyword is lost. I reported a bug to Unity and didn't get any reply yet.

@hiroj
Copy link
Contributor Author

hiroj commented Apr 24, 2019

Thanks for the report

@hiroj
Copy link
Contributor Author

hiroj commented Apr 24, 2019

Santarh/MToon#44

@SetoKaiba
Copy link

@hiroj After a deeper dig, I found out the problem is caused by the line below.
UsePass "Standard/SHADOWCASTER"
The problem is introduced by the new modification on Standard.shader. It uses shader_feature_local instead of shader_feature.
The shader_feature_local will just make the keywords for multi_compile and shader_feature not working anymore.
And also, the problem can't be reverted. Once you compiled the shader with shader_feature_local. Even you remove the lines.
The keyword will still not work.

The temp workaround is to delete the shader. And use the code below for a temp fix. I'll still wait for the replies from official and give more updates here.

			Pass {
				Name "ShadowCaster"
				Tags { "LightMode" = "ShadowCaster" }

				ZWrite On ZTest LEqual

				CGPROGRAM
				#pragma target 3.0

				// -------------------------------------


				#pragma shader_feature _ _ALPHATEST_ON _ALPHABLEND_ON _ALPHAPREMULTIPLY_ON
				#pragma shader_feature _METALLICGLOSSMAP
				#pragma shader_feature _SMOOTHNESS_TEXTURE_ALBEDO_CHANNEL_A
				#pragma shader_feature _PARALLAXMAP
				#pragma multi_compile_shadowcaster
				#pragma multi_compile_instancing
				// Uncomment the following line to enable dithering LOD crossfade. Note: there are more in the file to uncomment for other passes.
				//#pragma multi_compile _ LOD_FADE_CROSSFADE

				#pragma vertex vertShadowCaster
				#pragma fragment fragShadowCaster

				#include "UnityStandardShadow.cginc"

				ENDCG
			}

@SetoKaiba
Copy link

MToon merged the workaround. Maybe update the MToon for VRM as well?

@hiroj
Copy link
Contributor Author

hiroj commented May 8, 2019

Yes, fetch updates and advance versions.

@hiroj
Copy link
Contributor Author

hiroj commented Jun 3, 2019

Supported by version 0.52

@hiroj hiroj closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants