Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert UV rotation direction of MToon 1.0 import/export. #1841

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Invert UV rotation direction of MToon 1.0 import/export. #1841

merged 1 commit into from
Oct 4, 2022

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented Oct 4, 2022 •
edited
Loading

#1826 was wrong interpretation.
This pull request is correct.

glTF uses U-right V-down space in the texture coords. [refs]
Unity uses U-right V-up space in the texture coords. [refs]

Directions of the positive rotation value

\ glTF (KHR_texture_transform & vrmc_materials_mtoon-1.0) Unity
uv in mathematical coords CW (U-right V-up space) CCW (U-right V-up space)
uv in texture coords CCW (U-right V-down space) [specification] CCW (U-right V-up space)
image on mesh CW 👍 CW 👍

reference:
KhronosGroup/glTF#1624

@Santarh Santarh mentioned this pull request Oct 4, 2022
Merged
@Santarh Santarh requested a review from ousttrue October 4, 2022 06:59
@ousttrue ousttrue requested a review from 0b5vr October 4, 2022 08:00
ousttrue
ousttrue approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仕様の解釈が正しくなる

@ousttrue ousttrue merged commit 903cfde into vrm-c:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

@0b5vr 0b5vr Awaiting requested review from 0b5vr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Santarh @ousttrue