change! (VRM Animation): change lookAt control method #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: lookAt control method is now local rotation instead of model space position The definition of model space is no longer needed so I removed the section This commit also contains several minor improvements which clarifies the spec
0b5vr
force-pushed
the
lookat-rotation
branch
from
0d48b15 to
913c9e3
Compare
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Nov 20, 2023
…model space translation See: vrm-c/vrm-specification#456 transfer quaternion to VRMLookAt yaw-pitch using VRMLookAtQuaternionProxy (does it look good?)
|
以下、2FPSのデータで申し訳ないですが、本PRの仕様で、Humanoid (rightUpperArm90度を下げる)・Expression (Happy)・LookAt （左を90度向く）が含まれたアニメーションです。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VRMアニメーションにおいて、lookAtの制御をモデル空間の位置からローカル空間の回転に変更しました。これは破壊的変更です。
この変更により、仕様内でモデル空間について定義をする必要はなくなったため、該当するセクションを削除しました。
また、本PRには、仕様を明確にするためのいくつかの小さな文言変更も含まれます。