fix(appsync): strongly type expires prop in apiKeyConfig (#9122)
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**[ISSUE]** `apiKeyConfig` has prop `expires` that has unclear documentation/not strongly typed and is prone to user errors. **[APPROACH]** Force `expires` to take `Expiration` class from `core` and will be able to output api key configurations easily through `Expiration` static functions: `after(...)`, `fromString(...)`, ` atDate(...)`, `atTimeStamp(...)`. Fixes #8698 BREAKING CHANGE: force `apiKeyConfig` require a Expiration class instead of string - **appsync**: Parameter `apiKeyConfig` takes `Expiration` class instead of `string` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ISSUE]
apiKeyConfighas propexpiresthat has unclear documentation/not strongly typed and is prone to user errors.[APPROACH]
Force
expiresto takeExpirationclass fromcoreand will be able to output api key configurations easily throughExpirationstatic functions:after(...),fromString(...),atDate(...),atTimeStamp(...).Fixes aws#8698
BREAKING CHANGE: force
apiKeyConfigrequire a Expiration class instead of stringapiKeyConfigtakesExpirationclass instead ofstringBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license