For mozilla-mobile#140 - Fixes a11y recomendations for the homeview

vrudesai · Feb 2, 2019 · 383f919 · 383f919
1 parent d46e435
commit 383f919
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml
@@ -18,6 +18,7 @@
         android:layout_marginTop="16dp"
         android:background="?android:attr/selectableItemBackgroundBorderless"
         android:src="@drawable/ic_menu"
+        android:contentDescription="@string/content_description_menu"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
 
@@ -27,6 +28,7 @@
         android:layout_height="@dimen/glyph_button_height"
         android:background="?android:attr/selectableItemBackgroundBorderless"
         android:src="@drawable/ic_private_browsing"
+        android:contentDescription="@string/content_description_private_browsing_button"
         app:layout_constraintEnd_toStartOf="@id/menuButton"
         app:layout_constraintTop_toTopOf="@id/menuButton" />
 

diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
@@ -17,7 +17,7 @@
     <color name="icons">#20233E</color>
 
     <color name="session_list_empty_bg">#1A665BFD</color>
-    <color name="session_list_empty_fg">#665BFD</color>
+    <color name="session_list_empty_fg">#544CD9</color>
     <color name="session_list_header">#6D6D6E</color>
 
     <color name="searchPillBackground">#FAFAFC</color>

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -7,6 +7,12 @@
     <string name="menu_share_with">Share with…</string>
     <string name="browser_home_button">Home</string>
 
+    <!-- Home view -->
+    <!-- Content description (not visible, for screen readers etc.): "Three dot" menu button. -->
+    <string name="content_description_menu">More options</string>
+    <!-- Content description (not visible, for screen readers etc.): "Private Browsing" menu button. -->
+    <string name="content_description_private_browsing_button">Enable Private Browsing</string>
+
     <!-- Browser Menu -->
     <string name="browser_menu_back">Back</string>
     <string name="browser_menu_forward">Forward</string>