forked from openshift/installer
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix okd upstream for amd64 #2
Open
palonsoro
wants to merge
16
commits into
vrutkovs:release-4.7-okd
Choose a base branch
from
palonsoro:fix-okd-upstream
base: release-4.7-okd
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build flag enables community-only modifications to the installer
This adds `Dockerfile.okd` image, which has RHCOS bootimage locations replaced with FCOS counterparts.
Update CVO upstream setting from OCP Cincinnati to OKD's release-controller
Some platforms are not supported by OKD installer, so these should be skipped. initramfs, iso and kernel have different formats in fcos meta file. Official Azure image is not yet uploaded to the Marketplace
OKD is using plain FCOS, which doesn't have MCD binary to pivot. It should extract it from machine-config-daemon image and run pivot manually. This also extract necessary files and manifests from machine-os-content image
This is noop on RHCOS, but useful for OKD. If an older stable image is used Zincati may update bootstrap node during bootstrapping, so it should be disabled
In 4.6+ `authentication` operator needs additional setting to allow single kube-apiserver instance.
Change source_uri to source because on OKD we download the FCOS image locally before uploading it to Azure.
Set DNS_IP via systemd-resolved if the service is running
Single `wait` seems to hang on recent FCOS
vrutkovs
force-pushed
the
release-4.7-okd
branch
from
August 5, 2021 18:04
af0c206
to
c4b7808
Compare
vrutkovs
force-pushed
the
release-4.7-okd
branch
from
August 20, 2021 10:47
c4b7808
to
156120c
Compare
vrutkovs
force-pushed
the
release-4.7-okd
branch
from
October 3, 2021 08:52
f44bc61
to
0d49e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKD upstream URL became invalid as per this known issue
Although this fix might work only for amd64, this is going to be better than just having it wrong by default.
BTW, I made the PR here because this is the repo used to build the installer as per
oc adm release info --commit-urls
. If that is wrong, please let me know.