Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3.4 #42

Merged
merged 2 commits into from
Jun 15, 2018
Merged

Version 1.3.4 #42

merged 2 commits into from
Jun 15, 2018

Conversation

vsanthanam
Copy link
Owner

  • What kind of change does this pull request introduce? (Bug fix, feature, etc.)
    API is updated to use external & internal parameter name preferredStyle instead of style in initializers & factory methods, to better match the UIAlertController API.

  • What is the current behavior? (You can also link to an open issue here)

The current API uses internal & external parameter name style for VSAlertController initializers

  • What is the new behavior, if applicable?

style is deprecated in favor of preferredStyle

  • Does this pull request introduce a breaking change? (What changes do users of older releases need to make?)

Yes! Older users will need to replace the older initializers & factory methods with the newer ones.

  • Anything else people should know?

Nah fam. We good, we good.

@vsanthanam vsanthanam merged commit 5d4bfaf into master Jun 15, 2018
@vsanthanam vsanthanam deleted the version-1.3.4 branch June 15, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant