Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user about samplerate being other than 44100 (was: Recording seems to skip steps) #129

Closed
MartiniMoe opened this issue Jan 17, 2024 · 9 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@MartiniMoe
Copy link

image

On the left you can see my track in Renoise. On the right is Sointu after recording the notes from renoise. As you can see there is a skipped empty step at 05/06. This repeats on steps 12/13, 1F/20 and so on.

Any idea what is causing this?

@vsariola
Copy link
Owner

Maybe Sointu doesn't get BPM from host correctly? Try setting BPM manually to correct before recording. Alternatively, there is some rounding issue with the rounding of MIDI events frames to row numbers. I'll investigate

@vsariola
Copy link
Owner

So things go wrong somehow here:

func frameToRow(BPM float64, rowsPerBeat, frame int) int {

@vsariola
Copy link
Owner

I don't know how Renoise does BPM changes but if the BPM doesn't stay constant for some reason, it could explain

@MartiniMoe
Copy link
Author

Hmm, both were set to the same bpm

@vsariola
Copy link
Owner

Maybe you are at 48000 samplerate, while Sointu assumes fixed 44100?

@MartiniMoe
Copy link
Author

Maybe you are at 48000 samplerate, while Sointu assumes fixed 44100?

Ah, that was it! 🎉

I'm using pipewire and running pw-metadata -n settings 0 clock.force-rate 44100 fixed this for me! Thank a lot :)

@vsariola vsariola reopened this Jan 17, 2024
@vsariola
Copy link
Owner

I'll make this into a feature request: warn user about wrong samplerate & document the requirement for 44100. Granted, in the year 2024, that number could be 48000. But there's historical baggage here.

@vsariola vsariola changed the title Recording seems to skip steps Warn use about samplerate being other than 44100 (was: Recording seems to skip steps) Jan 17, 2024
@vsariola vsariola changed the title Warn use about samplerate being other than 44100 (was: Recording seems to skip steps) Warn user about samplerate being other than 44100 (was: Recording seems to skip steps) Jan 17, 2024
@vsariola vsariola added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 17, 2024
@vsariola
Copy link
Owner

vsariola commented Jan 18, 2024

Nice to hear you are able to compile & run the VSTI on Linux btw :)

@vsariola
Copy link
Owner

This should get the job done:
image

vsariola added a commit that referenced this issue Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants