Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing instruments over the tracker UI button assigns duplicate unit IDs #146

Closed
LeStahL opened this issue Sep 5, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@LeStahL
Copy link
Contributor

LeStahL commented Sep 5, 2024

When exporting instruments over the "Save Instrument" button in the tracker and re-importing them using the "Load Instrument" button, the same unit IDs like in the instrument file are used for its units, regardless of whether or not those units already exist in the patch.

@vsariola
Copy link
Owner

vsariola commented Sep 5, 2024

Damn. Must fix soon, this is where they come from.

@vsariola vsariola added the bug Something isn't working label Sep 5, 2024
vsariola added a commit that referenced this issue Sep 6, 2024
@vsariola
Copy link
Owner

vsariola commented Sep 6, 2024

Ok, I firstly assign IDs when loading an instrument and I also made a paranoid thing: always check for ID collisions and if they somehow happen, automatically fix them by giving a completely new ID to the later unit(s) having same ID as the first one.

@LeStahL
Copy link
Contributor Author

LeStahL commented Sep 6, 2024

super cool, thanks for looking into this so quickly! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants