Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LanguageConfiguration API method #53

Merged
merged 12 commits into from
Nov 6, 2023
Merged

Implement LanguageConfiguration API method #53

merged 12 commits into from
Nov 6, 2023

Conversation

zm-cttae
Copy link
Member

@zm-cttae zm-cttae commented Oct 26, 2023 •
edited
Loading

🏗️ Pull Request

  • Used a clear / meaningful title for this pull request.
  • Tested the changes on your own grammar (on your projects).
  • Added / Edited tests to reflect changes (test folder).
  • Have read the Contributing part of the README.
  • Passed npm test.
  • I noted my changes in the pull request body and/or changelog.

👷🏾‍♀️ Fixes

Related to #52.

Description

Add support for loading language-configuration.json files in the vscode.LanguageConfiguration format.

What changes have you made?

  • Add getLanguageConfiguration API method to load vscode.LanguageConfiguration.
  • [BREAKING] Rename getLanguageConfiguration to getLanguageContribution.
  • [BREAKING] Rename getGrammarConfiguration to getGrammarContribution.

What tests have you completed?

  • Tested this in Visual Studio Code v1.83.1.
  • Tested this in Visual Studio Code Insiders v1.84.0.
  • Tested this for GitHub Codespaces v1.84.0.
  • Tested this in VSCodium v1.83.1.

Anything else worth mentioning?

Due to the breaking changes, this is a major semver version bump. We are folding 2.1.0 into a 3.0.0 release.

@zm-cttae zm-cttae added this to the 3.0.0 milestone Nov 2, 2023
@zm-cttae zm-cttae merged commit 5ed27d3 into release-candidate/3.0.0 Nov 6, 2023
2 checks passed
zm-cttae added a commit that referenced this pull request Nov 6, 2023
@zm-cttae
Fix failing tests for #53
e353a5b
zm-cttae added a commit that referenced this pull request Nov 6, 2023
@zm-cttae
Lint diff for #53
368f255
@zm-cttae zm-cttae deleted the feat-language-configuration branch November 6, 2023 18:04
zm-cttae added a commit that referenced this pull request Nov 7, 2023
@zm-cttae
Fix failing tests for #53
12c7040
zm-cttae added a commit that referenced this pull request Nov 7, 2023
@zm-cttae
Lint diff for #53
9268bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
context-services modifier-integrations A new frontier (product or platform) for the library! priority-high scope-functionality status-complete type-debt type-feature
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@zm-cttae