Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3.0.0 missing type definition #57

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

zm-cttae
Copy link
Member

🏗️ Pull Request

  • Used a clear / meaningful title for this pull request.
  • Tested the changes on your own grammar (on your projects).
  • Added / Edited tests to reflect changes (test folder).
  • Have read the Contributing part of the README.
  • Passed npm test.
  • I noted my changes in the pull request body and/or changelog.

👷🏾‍♀️ Fixes

Related to #56.

Description

Fix and regression test type definition breakage for the library.

What changes have you made?

  • Hotfix for type definitions missing in 3.0.0.

What tests have you completed?

  • Tested this in Visual Studio Code v1.85.2.
  • Tested this in Visual Studio Code Insiders v1.86.0.
  • Tested this for GitHub Codespaces v1.86.0.
  • Tested this in VSCodium v1.85.2.

Anything else worth mentioning?

This release also adds regression testing so that type breakage doesn't reoccur.

@zm-cttae zm-cttae merged commit afb44b1 into release-candidate/3.0.1 Feb 7, 2024
2 checks passed
@zm-cttae zm-cttae deleted the hotfix-type-definition-missing branch February 7, 2024 18:03
@zm-cttae zm-cttae changed the title Fix v3.0.0 missing type definition (#56) Fix v3.0.0 missing type definition Feb 7, 2024
@zm-cttae zm-cttae changed the title Fix v3.0.0 missing type definition Fix 3.0.0 missing type definition Feb 7, 2024
@zm-cttae zm-cttae added this to the 3.0.1 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant