Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defensive check as outputPath is not guaranteed to be a string #2

Merged
merged 2 commits into from
Feb 14, 2021
Merged

defensive check as outputPath is not guaranteed to be a string #2

merged 2 commits into from
Feb 14, 2021

Conversation

peterjcaulfield
Copy link
Contributor

See 11ty/eleventy#653 for more details.

As it stands, this plugin transform breaks builds that try to avail of the 11ty permalink: false API that is used for things like draft posts.

vseventer
vseventer requested changes Feb 12, 2021
View reviewed changes
Copy link
Owner

@vseventer vseventer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment - but good catch, thanks!

eleventy.js Outdated Show resolved Hide resolved
@vseventer vseventer added the bug Something isn't working label Feb 12, 2021
@peterjcaulfield @vseventer
Favour optional chaining
70e3ba7 
Co-authored-by: Mark van Seventer <mark@vseventer.com>
@vseventer vseventer merged commit d370081 into vseventer:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vseventer vseventer vseventer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjcaulfield @vseventer