Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sharp to add Apple M1 support #65

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Update sharp to add Apple M1 support #65

merged 2 commits into from
Jun 18, 2022

Conversation

vseventer
Copy link
Owner

@vseventer vseventer commented Jun 18, 2022 •
edited
Loading

This Pull Request:

  • Updates sharp dependency to support Apple M1.
  • Removes --limitInputPixels and --sequentialRead flags no longer supported by sharp.

Things to Note

  • This fixes Support Apple M1 laptops: bump sharp to 0.29.1 #61.
  • There's a failing test impacting writing back to the input file - it appears the rw-stream package no longer works with latest Node.js so I have to find a replacement. This seems to have been implemented by sharp itself.

@vseventer vseventer added this to the v2.0.0 milestone Jun 18, 2022
@vseventer vseventer self-assigned this Jun 18, 2022
@vseventer vseventer added dependencies Pull requests that update a dependency file and removed enhancement labels Jun 18, 2022
@vseventer vseventer mentioned this pull request Jun 18, 2022
Closed
@vseventer vseventer merged commit 1c4ef81 into master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vseventer vseventer

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@vseventer