Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler Class Extension and Method Signature Updates #16

Merged
merged 6 commits into from
Jul 15, 2023
Merged

Conversation

vsevex
Copy link
Owner

@vsevex vsevex commented Jul 15, 2023

Here is a brief overview of the changes that have been made and the beautified code:

  1. Handler class Extension: The Handler class now extends EventObject (named as Event<T> in the project). This modification was done to improve the handling of incoming stanzas and to separate result and error stanzas using the Dartz package. With this enhancement, we can now easily categorize stanzas as error and result stanzas.
  2. addHandler Method Signature Updates: The addHandler method has been updated to accept two additional parameters: resultCallback and errorCallback. These methods play a crucial role in running various executions based on the type of stanzas received, enabling better control over the handling of results and errors.

As a consequence of these changes, some breaking changes have occurred in the codebase, including the logical changes in extensions like disco, pubsub, and v-card.

Versions Affected:
v0.0.1, v0.0.5, v0.0.55

@vsevex vsevex added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 15, 2023
@vsevex vsevex self-assigned this Jul 15, 2023
@vsevex vsevex merged commit 0a02716 into main Jul 15, 2023
@vsevex vsevex linked an issue Jul 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implementation of XEP-0077: In-Band Registration
1 participant