Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minio end-user docs #94

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Add Minio end-user docs #94

merged 3 commits into from
Nov 2, 2023

Conversation

Kidswiss
Copy link
Contributor

These docs explain how customers can get Minio on their clusters.

Minio is a bit a special case and usually not enabled by default, as the cloud provider's object storage is preferred by default.

Full self-service provision for Minio is unfortunately not that trivial to achieve, as each Minio instance will require a separate composition pointing to that instance and wiring up the credentials to work with the ObjectBucket objects.

So to get full self-service for Minio we'd need to engineer a composition which in turn creates new compositions on the fly. While it's doable with composition functions, it's a construct that can pretty easily explode in complexity.

Unless full self-service Minio is something our customers really crave, I'd suggest keeping it as described in the docs and put that effort in other services on the roadmap.

@Kidswiss Kidswiss requested review from tobru, a team, TheBigLee, wejdross and zugao and removed request for a team October 31, 2023 14:28
@tobru
Copy link
Member

tobru commented Oct 31, 2023

I pushed f96357f - what do you think?

Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some duplicates. I checked with make preview but everything seems fine, no duplicates, strange.

docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the duplicates and the rest just LGTM

@tobru
Copy link
Member

tobru commented Nov 2, 2023

removing the duplicates and the rest just LGTM

I don't understand what you mean with duplicates? Yes, some lines are duplicated because they point to the same place, in a different column.

@Kidswiss Kidswiss merged commit cf3e313 into master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants