Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SSLMode for provider-sqls provider-config #303

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Feb 4, 2025

Summary

We need to pass the correct ssl mode to the provider-config for provider-sql in order to be able to connect to the postgresql server depending on the ssl mode of the server itself.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@TheBigLee TheBigLee added the bug Something isn't working label Feb 4, 2025
We need to pass the correct ssl mode to the provider-config for
provider-sql in order to be able to connect to the postgresql server
depending on the ssl mode of the server itself.

Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
@TheBigLee TheBigLee requested review from a team, wejdross and zugao and removed request for a team February 4, 2025 10:36
@TheBigLee TheBigLee added the patch label Feb 4, 2025
Copy link
Member

@wejdross wejdross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume You tested it already if it creates roles correctly?

@TheBigLee TheBigLee merged commit 85f3ef8 into master Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants