Add note on devcontainer building #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsntTheWay
changed the title
1 task
lieneluksika
requested review from
a team,
Kidswiss,
TheBigLee and
wejdross
and removed request for
a team
TheBigLee
reviewed
Feb 4, 2025
README.md
Outdated
| > On linux, Podman and rootless Docker have been found to cause issues. | ||
| > Ensure that you are using **rootful Docker** to save yourself loads of trouble. | ||
| > | ||
| > Additionally, on linux, you might encounter issues with `iptables`. |
There was a problem hiding this comment.
Some of the part is rather specific to Fedora. Probably best to mention that some of the stuff is specific to that.
E.g On Arch the iptables package is already the "legacy" one.
Afaik on Ubuntu the package is also called iptables-legacy.
There isn't a need to specify it for all flavors, just mention that the example you specified is specific to Fedora
wejdross
approved these changes
Feb 4, 2025
README.md
Outdated
Comment on lines
72
to
84
| > On linux, Podman and rootless Docker have been found to cause issues. | ||
| > Ensure that you are using **rootful Docker** to save yourself loads of trouble. | ||
| > | ||
| > Additionally, on linux, you might encounter issues with `iptables`. | ||
| > Execute the following on the host prior to building the devcontainer: | ||
| > ```bash | ||
| > sudo dnf install -y iptables-legacy | ||
| > sudo modprobe ip_tables | ||
| > echo 'ip_tables' | sudo tee /etc/modules | ||
| > ``` | ||
| > | ||
| > *To further debug dind, consult `/tmp/dockerd.log` in the container.* | ||
|
|
There was a problem hiding this comment.
Suggested change
| > On linux, Podman and rootless Docker have been found to cause issues. | |
| > Ensure that you are using **rootful Docker** to save yourself loads of trouble. | |
| > | |
| > Additionally, on linux, you might encounter issues with `iptables`. | |
| > Execute the following on the host prior to building the devcontainer: | |
| > ```bash | |
| > sudo dnf install -y iptables-legacy | |
| > sudo modprobe ip_tables | |
| > echo 'ip_tables' | sudo tee /etc/modules | |
| > ``` | |
| > | |
| > *To further debug dind, consult `/tmp/dockerd.log` in the container.* | |
| > On linux, Podman and rootless Docker have been found to cause issues. | |
| > (...) | |
| > Please refer to official documentation under: https://docs.docker.com/engine/install/ |
There was a problem hiding this comment.
Addendum incorporated in 5025f5f
Kidswiss
approved these changes
Feb 5, 2025
TheBigLee
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog