fix: Ensure APIs can be used by other Go modules #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutter
force-pushed
the
fix/go-mod-version
branch
from
cc5d7e2
to
30205fe
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mhutter
force-pushed
the
fix/go-mod-version
branch
from
30205fe
to
86a8784
Compare
The go module versioning rules states that packages with a major version greater than v1 must have a major version suffix (https://go.dev/ref/mod#module-path) Since the latest versions of this project are v4, the module name must end in `/v4`. Otherwise, - regular 'go get' will fetch v0.2.3 of this repo - 'go get ...@v4.18.1' will complain that the module name is invalid. Signed-off-by: Manuel Hutter <manuel@hutter.io>
zugao
force-pushed
the
fix/go-mod-version
branch
from
86a8784
to
61022b3
Compare
Kidswiss
approved these changes
Aug 22, 2023
Merged
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The go module versioning rules states that packages with a major version greater than v1 must have a major version suffix
(https://go.dev/ref/mod#module-path)
Since the latest versions of this project are v4, the module name must end in
/v4. Otherwise,vshn/appcat-cli#16
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog