Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub-items to invoice #41

Merged
merged 8 commits into from
May 11, 2022
Merged

Add sub-items to invoice #41

merged 8 commits into from
May 11, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented May 9, 2022

Summary

Adds CPU request and Memory request sub-items to compute item, if they exist.

Also slightly extends the golden tests.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@glrf glrf added the enhancement New feature or request label May 9, 2022
@glrf glrf self-assigned this May 9, 2022
@glrf glrf force-pushed the feat/subitems branch from f238230 to 369b83e Compare May 9, 2022 15:52
@glrf glrf force-pushed the feat/subitems branch 2 times, most recently from f6a655b to 07a81ff Compare May 10, 2022 12:23
@glrf glrf force-pushed the feat/subitems branch from b7c3ed1 to 907bfaf Compare May 10, 2022 14:10
@glrf glrf marked this pull request as ready for review May 10, 2022 14:12
@glrf glrf requested review from bastjan and corvus-ch May 10, 2022 14:13
description_templates/golden_test.go Outdated Show resolved Hide resolved
description_templates/golden_test.go Show resolved Hide resolved
@glrf
Copy link
Contributor Author

glrf commented May 11, 2022

I'll merge this now to finally get this to production. Formatting changes can easily be added in a later PR

@glrf glrf merged commit 2595f83 into master May 11, 2022
@glrf glrf deleted the feat/subitems branch May 11, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants