Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make component multi-instance capable #16

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Make component multi-instance capable #16

merged 3 commits into from
Oct 13, 2022

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Oct 12, 2022

Summary

  • Added k8s environment variables available to the component.
  • Changed the component to allow multi instance feature.
  • Added golden tests.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@zugao zugao requested review from ccremer and Kidswiss October 12, 2022 08:27
@ccremer ccremer changed the title Update component to be compatible with the application Make component multi-instance capable Oct 12, 2022
@zugao zugao force-pushed the update-component branch 2 times, most recently from aa8e1cc to a197784 Compare October 12, 2022 09:14
ccremer
ccremer reviewed Oct 12, 2022
View reviewed changes
component/class/defaults.yml Outdated Show resolved Hide resolved
component/component/main.jsonnet Outdated Show resolved Hide resolved
component/component/main.jsonnet Outdated Show resolved Hide resolved
@zugao zugao requested a review from ccremer October 12, 2022 12:07
ccremer
ccremer suggested changes Oct 12, 2022
View reviewed changes
component/class/defaults.yml Outdated Show resolved Hide resolved
component/tests/golden/defaults/defaults/defaults/cronjob.yaml Outdated Show resolved Hide resolved
component/tests/golden/defaults/defaults/defaults/secrets.yaml Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/installation.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/installation.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/installation.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/installation.adoc Show resolved Hide resolved
Kidswiss
Kidswiss approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not versed enough in jsonnet/component development to give meaningful feedback here.

If it works I guess it's fine by me.

@zugao zugao requested a review from ccremer October 12, 2022 15:32
ccremer
ccremer reviewed Oct 12, 2022
View reviewed changes
docs/modules/ROOT/pages/how-tos/multi-instance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/multi-instance.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/multi-instance.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/installation.adoc Outdated Show resolved Hide resolved
component/component/main.jsonnet Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/installation.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
@zugao zugao requested a review from ccremer October 13, 2022 08:14
ccremer
ccremer approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things, then LGTM

component/tests/collector-cloudscale-lpg-2.yml Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/multi-instance.adoc Outdated Show resolved Hide resolved
@zugao zugao merged commit 8dffc8f into master Oct 13, 2022
@zugao zugao deleted the update-component branch October 13, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

@Kidswiss Kidswiss Kidswiss approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zugao @Kidswiss @ccremer