Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Control Plane from Service Cluster #536

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Separate Control Plane from Service Cluster #536

merged 1 commit into from
Nov 18, 2024

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Nov 15, 2024

This PR helps to separate manifests depending cluster management system. At this stage it cannot separate precisely each manifest as this will be decided further when we adjust various applications.

There's nothing to add for providers at the moment. This has to be done when installing the component and adding provider configs in additionalProviderConfigs for each provider.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@zugao zugao added the enhancement New feature or request label Nov 15, 2024
@zugao zugao force-pushed the control-plane branch 2 times, most recently from 76ac830 to 1a32bc3 Compare November 15, 2024 12:26
@zugao zugao requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team November 15, 2024 12:28
@zugao zugao force-pushed the control-plane branch 5 times, most recently from 1a3b46f to e5d271b Compare November 18, 2024 10:24
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I wonder if we can streamline this a bit more in the future? It's just a matter of time someone forgets to set the right if clause for some new functionality...

postprocess/crossplane.jsonnet Show resolved Hide resolved
postprocess/crossplane.jsonnet Show resolved Hide resolved
@zugao
Copy link
Contributor Author

zugao commented Nov 18, 2024

However, I wonder if we can streamline this a bit more in the future? It's just a matter of time someone forgets to set the right if clause for some new functionality...

I agree but at the moment I have no idea how we could streamline this better. In the end the engineer will still have to decide himself where each manifests should end up.

@zugao zugao changed the title Add Control Plane support Separate Control Plane from Service Cluster Nov 18, 2024
@zugao zugao merged commit 049e980 into master Nov 18, 2024
32 checks passed
@zugao zugao deleted the control-plane branch November 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants