Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate golden tests #544

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Consolidate golden tests #544

merged 1 commit into from
Nov 20, 2024

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Nov 19, 2024

Consolidated the golden tests. The running time of target gen-golden-all went down from 5m10s to 3m10s.

  • This PR removes unnecessary golden tests and adds the configuration in both vshn-cloud and vshn-managed golden tests.
  • The Cluster Management System also has it's own 2 tests.
  • We keep the defaults and use the old vshn golden test as dev with proxyFunction set to true.
  • Removed make test target from the Pipeline as it was doing the same as diff

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@zugao zugao added the enhancement New feature or request label Nov 19, 2024
@zugao zugao force-pushed the golden-tests branch 4 times, most recently from 1d83b8e to 43ffae1 Compare November 19, 2024 15:58
@zugao zugao requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team November 19, 2024 16:00
@Kidswiss
Copy link
Contributor

  • We keep the defaults and use the old vshn golden test as dev with proxyFunction set to true.

I like the renaming of the test, but I'm a bit torn about setting proxy default.

  • If we want to quickly test a bug in master we'd have to change it
  • AFAIK the default endpoints don't work on linux anyway and need a recompile

@zugao
Copy link
Contributor Author

zugao commented Nov 19, 2024

Any good ideas how we can improve that? Or I just remove the dev aka ex vshn test file.

Update: or just leave it as it was

Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just leaving the vshn/dev golden as is 👍

@zugao zugao merged commit 427cc85 into master Nov 20, 2024
10 checks passed
@zugao zugao deleted the golden-tests branch November 20, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants