Reduce provider-kubernetes' API load #550
Merged
+26
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
zugao
reviewed
Nov 25, 2024
| securityContext: {} | ||
| securityContext: {} | ||
| serviceAccountName: provider-kubernetes |
There was a problem hiding this comment.
I think this should not be deleted?
There was a problem hiding this comment.
Good catch, I wonder why it doesn't merge this cleanly...
zugao
reviewed
Nov 25, 2024
Kidswiss
force-pushed
the
change/kube-reconcile-rate
branch
from
d904359
to
0c8c925
Compare
we've observed if many instances are created at the same time, the objects might need manual intervention due to the `create-pending` annotation. This change will reduce the API load on the apiservers to reduce the chances of this actually happening.
Kidswiss
force-pushed
the
change/kube-reconcile-rate
branch
from
0c8c925
to
af2a920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've observed if many instances are created at the same time, the objects might need manual intervention due to the
create-pendingannotation.This change will reduce the API load on the apiservers to reduce the chances of this actually happening.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.