Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parent keepalived check and oom score adjustment in test mode #93

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

simu
Copy link
Member

@simu simu commented Jul 3, 2024

Summary

We don't need to check for a keepalived parent process or adjust our own OOM score when running the self-test. This change should allow running the Floaty self-test as a non-root user as long as that user can access the Floaty config file.

Extracted from #92

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update the documentation.
  • Link this PR to related issues.

@simu simu added the enhancement New feature or request label Jul 3, 2024
@simu simu requested a review from a team July 3, 2024 14:27
@simu simu marked this pull request as ready for review July 3, 2024 14:27
@simu simu force-pushed the feat/nonroot-self-test branch from 63acd4a to e1b1127 Compare July 8, 2024 08:08
@simu simu merged commit cf27138 into master Jul 8, 2024
2 checks passed
@simu simu deleted the feat/nonroot-self-test branch July 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants