Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for Debian 12 #86

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Add steps for Debian 12 #86

merged 3 commits into from
Jul 5, 2024

Conversation

SzymonOzog
Copy link
Contributor

'libwxgtk3.0-gtk3-dev' is unavailable for debian 12, replaced with appropriate packages

@vslavik
Copy link
Owner

vslavik commented Jul 5, 2024

Thanks, but can you please update it to apply to both Debian and Ubuntu and be universal, i.e.:

  • Debian 12 / Ubuntu XY or newer: ...new instructions...
  • Older Debian / Ubuntu: ...current instructions...

?

TIA!

@SzymonOzog
Copy link
Contributor Author

Sure thing, updated the debian versions - ubuntu instructions should work an all releases

@vslavik
Copy link
Owner

vslavik commented Jul 5, 2024

Well, I mean Ubuntu is a Debian derivative, so clearly there's a Ubuntu version that the update applies to as well (24.04, apparently), and going forward that should take priority. I pushed an update accordingly in 531a188.

Upon further review, the "libwxgtk-webview3.2-1 libwxgtk-webview3.2-dev" is highly suspect and I'm not sure why you did it? The former is redundant (being a dependency of the latter) and diff-pdf doesn't use the webview component at all. So this doesn't make sense and the entire change should instead be a change to 3.2 and the new package naming.

Please verify (i.e. uninstall the *webview* packages you installed and try the corrected instructions).

@SzymonOzog
Copy link
Contributor Author

Can confirm that it works with just the dev package

@vslavik vslavik merged commit 6cf5110 into vslavik:master Jul 5, 2024
3 checks passed
@vslavik
Copy link
Owner

vslavik commented Jul 5, 2024

Thanks!

Repository owner deleted a comment from A50garmin Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants