Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support listLimit param in /stock/market/list/{list-type} #2

Closed
persia92 opened this issue Jan 24, 2020 · 1 comment · Fixed by #38
Closed

Please support listLimit param in /stock/market/list/{list-type} #2

persia92 opened this issue Jan 24, 2020 · 1 comment · Fixed by #38
Labels
enhancement New feature or request

Comments

@persia92
Copy link

/stock/market/list/{list-type}
Please give support all Query String Parameters for this api.
Link: https://iexcloud.io/docs/api/#list

@JamiePrentice
Copy link
Collaborator

Looks like this is already supported.

See:

public async Task<IEXResponse<IEnumerable<Quote>>> ListAsync(string listType)

Or usage in tests:

var response = await sandBoxClient.Stock.ListAsync(listType);

@vslee vslee linked a pull request May 8, 2020 that will close this issue
@vslee vslee closed this as completed in #38 May 8, 2020
vslee pushed a commit that referenced this issue May 8, 2020
I ran into a few issues with the Dividend functionality. The DividendFrequency field in the Dividend class was not deserializing correctly because the response from IEXCloud was coming in as "quarterly" (i.e., all lowercase).

I was also seeing an issue when retrieving data for the "Next" dividend because the response from IEXCloud was no longer an array but was an object. I added a new method to the StockFundamentals class to handle this one-off case. I took the same approach with the "Splits" method as well and updated its tests since they were failing since there are no upcoming or prior splits for APPL.

Not sure if these are the most elegant solutions so I am open to feedback on both.

I also removed the EarningsToday method from the StockFundamentals service as it is duplicated in the MarketInfo service. I think that is where it belongs, but let me know if you would prefer to keep it in the StockFundamentals service as well.

Pull request also includes update to address issue #2 which was requesting support for the listLimit query string parameter for the market/list/{listType} endpoint.

Pull request also includes adding of the "Period" parameter to the Estimates method in the StockResearch service.

* Fixing issues with dividend (basic) functionality.

* Removing EarningsToday method from the StockFundamentals service since it is duplicated in the MarketInfo service which I think it where it belongs.

* Adding 'Next' split approach much like what was added for the 'Next' dividend case.

* Adding support for 'listLimit' parameter for market info list endpoint. Addresses issue #2.

* Updating Stock Research Service Estimates call to accept the Period parameter.

* Refactoring the 'Next' case for dividends and splits to use the dynamic keyword instead of adding another method to handle that case.

* Additional refactor for providing standardized interface for Dividend and Split responses when calling with the Next option.
@vslee vslee added the enhancement New feature or request label May 8, 2020
vslee added a commit that referenced this issue May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants