Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Economic Data Service #34

Merged
merged 13 commits into from
May 7, 2020
Merged

Adding Economic Data Service #34

merged 13 commits into from
May 7, 2020

Conversation

JamiePrentice
Copy link
Collaborator

Adding Economic Data Service (Mostly based on @longpshorn's work for Commodities Service)

@vslee
Copy link
Owner

vslee commented May 7, 2020

Oops, I created some conflicts by merging #33. Do you think you could resolve them for me to merge this?

@JamiePrentice
Copy link
Collaborator Author

Wasn't your fault @vslee - I used the same model in the same folder as @longpshorn so that we'd not have model duplication. Expected it to happen!

@vslee vslee added the enhancement New feature or request label May 7, 2020
@vslee vslee merged commit 6ed1d8c into vslee:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vslee vslee vslee approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamiePrentice @vslee