-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/stock missing fields #87
Feature/stock missing fields #87
Conversation
Will expand on this. Premature PR. Don't merge yet. |
With this expansion of fields, looking at https://iexcloud.io/docs/api/#income-statement and IncomeStatementResponse.cs I'm wondering if it would be safest here to make the majority of the values nullable. Curious about the consensis on this. |
Seem to have been added to a lot of the responses, it might be worth looking at a base response that includes these. |
There appears to be duplicate fields on Insider-Transactions. https://iexcloud.io/docs/api/#insider-transactions The descriptions of these data points are the same in the API docs, however they appear to be returning different values. This could be down to the fuzzing of data on the test API response however. |
- Removing fields that are no longer in use as of 01/12/2020. - Adding missing beta field.
+ Rearrange to match IEX Docs.
Ready for review. These are the updates for under the https://iexcloud.io/docs/api/#stocks-equities section. Not including
|
Ya, I think that would be the safest too.
Sounds good to me
You're right, I think it's just the obfuscation they're doing on the sandbox data. |
Beginning of picking up missing fields in the response types.
This is just: