Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to nullable to match data #98

Merged

Conversation

fcsobel
Copy link
Contributor

@fcsobel fcsobel commented Feb 7, 2021

Made nullable to match data and pass tests. These are defined as bool in docs but come across as 1, 0 or null. Could use custom converter or extra field to support as bool

Copy link
Owner

@vslee vslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A custom converter is a great idea.

@vslee vslee added the bug Either the bug, or the bug fix label Feb 7, 2021
@vslee vslee merged commit 0950726 into vslee:main Feb 7, 2021
@fcsobel fcsobel deleted the Update_DividendAdvancedResponse_To_Match_Data branch February 8, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Either the bug, or the bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants