guard against undefined value for field #517
Conversation
| @@ -25,13 +25,13 @@ export class MyEditorSelection { | |||
| } | |||
|
|
|||
| export function getEditorFromState(state: EditorState) { | |||
| const { editor } = state.field(editorInfoField); | |||
| const field = state.field(editorInfoField); | |||
There was a problem hiding this comment.
My fix just ignorantly addresses the immediate error that is being thrown. But perhaps there is a deeper bug that should prevent the visible error from being possible? The codemirror docs indicate that field() should throw an error if the requested field doesn't exist on the state. Since state.field() is not throwing the error, I assume that the field does exist on the state but its value is undefined. Perhaps this is an unexpected state?
There was a problem hiding this comment.
Yes, this fix will hide the error. However, as noted, it does have the potential to cause problems in other areas. It's better to find out why the editor is inaccessible here, and find a reliable way to access it in this context.
There was a problem hiding this comment.
That makes sense, although it seems like that logic should be in place for the subsequent conditional check that can return null, no?
Anyway, feel free to just close this PR if it's not the fix you're looking for. Thanks for the quick response!
Fixes #503