Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider exposing generated password from PasswordGenerator as a char array or buffer #126

Open
bindul opened this issue Mar 22, 2021 · 1 comment
Open

Consider exposing generated password from PasswordGenerator as a char array or buffer #126

bindul opened this issue Mar 22, 2021 · 1 comment

Comments

@bindul
Copy link

bindul commented Mar 22, 2021

It would be convenient to be able to get the generated password from PasswordGenerator as a char[] or CharBuffer. This would allow us to wipe out contents in the array to avoid Heap_Inspection risk flagged by Static Application Security Tool scans. Creating a String from the buffer with the generated password is disliked by those tools.
dfish3r added a commit that referenced this issue Jul 20, 2021
@dfish3r
Fix buffer overflow in password generator.
d8a799c 
When the requested length is less than number of characters in a rule a buffer overflow occurs.
See #126.
@maulijmehta
Copy link

Hi, I am facing with same in org.passay.PasswordData where password filed as String. If this password field as char[] this would help and resolve our Cleartext Storage of Sensitive Information in Memory issue flagged by veracode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bindul @maulijmehta