Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed a literal caomparison pitfall from the code #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NaelsonDouglas
Copy link

@NaelsonDouglas NaelsonDouglas commented Oct 24, 2021

The problem
In Python when comparing to non-singleton values, it advised to use the operator '==' instead of 'is'.
By doing otherwise, we may fall into the a code pitfall which can be detected by pylint under the identification of R0123 literal-comparison https://vald-phoenix.github.io/pylint-errors/plerr/errors/basic/R0123.html

The solution
Refactored the comparison on literals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant