Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions doesn't work on coded URLs #190

Open
jpgutti opened this issue May 6, 2019 · 7 comments
Open

Conditions doesn't work on coded URLs #190

jpgutti opened this issue May 6, 2019 · 7 comments

Comments

@jpgutti
Copy link

jpgutti commented May 6, 2019

Expected Behavior

Be able to change conditions even in a coded URL

Current Behavior

It looks like conditions doesn't work under a coded page url, the options can't be changed and I am "forced" to set up the configuration to the template

Context

I've created a simple component that I can set up a title and a description to a department/category/subcategory, in the blocks I put it just after the search results... It is working on departments/categories/subcategories that are simple like "Meias", but I can't change the conditions on subcategories like "Bonés", that is coded into "Bon%C3%A9s" .

@alcar
Copy link
Contributor

alcar commented Jun 10, 2019

Hey, @jpgutti! Sorry for the late reply.

Could you please send me a workspace where I can reproduce that issue?

@jpgutti
Copy link
Author

jpgutti commented Jun 11, 2019

Hey @alcar , here's the workspace https://vtexdebug--newbalance.myvtex.com/admin/cms/storefront

Navigate to subcategory "Bonés" within Female department and try to set up the "Category Text" block. I've noticed that now we have a toast message saying that it could't find a SubCategory.

After that, if you try any Department/Category/Subcategory that doesn't code URL you'll be able to set up the block correctly.

@jpgutti
Copy link
Author

jpgutti commented Jun 11, 2019

@alcar There's an error over vtex link console when we navigate to those ones that have coded url, if it helps...

09:28:09.537 - error: Error loading context data for type subcategory: Missing context data vtex.pages-graphql@2.50.6

@alcar
Copy link
Contributor

alcar commented Jun 12, 2019

@jpgutti I've just released a new Store GraphQL version that addresses that issue. Could you please check if everything works as expected?

@jpgutti
Copy link
Author

jpgutti commented Jun 12, 2019

@alcar Great! Things are working as expected now!

But the error toast still appears, would be nice if you fix that in the future for a better UX. :)

Thanks!

@alcar
Copy link
Contributor

alcar commented Jun 12, 2019

@jpgutti No problem!

Do you have an example scenario in which the toast still appears?

@jpgutti
Copy link
Author

jpgutti commented Jun 12, 2019

@alcar I've noticed in the same scenario I described above for the "Bonés" subcategory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants