Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: search context criteria #326

Merged
merged 3 commits into from
Jun 12, 2019
Merged

Fix: search context criteria #326

merged 3 commits into from
Jun 12, 2019

Conversation

alcar
Copy link
Contributor

@alcar alcar commented Jun 11, 2019

What is the purpose of this pull request?

  • Add support to categories, departments and subcategories whose URLs contain special characters;
  • Upgrade axios, since a vulnerability issue has been discovered in the current version.

What problem is this solving?

The following issue: vtex-apps/admin-pages#190.

It looks like conditions doesn't work under a coded page url, the options can't be changed and I am "forced" to set up the configuration to the template.

How should this be manually tested?

Reproducing the bug (taken from the aforementioned issue):

  1. Open the vtexdebug workspace from the newbalance account (link).

  2. Navigate to subcategory "Bonés" within Female department and try to set up the "Category Text" block. I've noticed that now we have a toast message saying that it could't find a SubCategory. After that, if you try any Department/Category/Subcategory that doesn't code URL you'll be able to set up the block correctly.


Testing the solution:

Repeat the steps above in the vtexdebugsolution workspace (link), and notice that you can now save the configuration for the Bonés subcategory.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

@alcar alcar self-assigned this Jun 11, 2019
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 11, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link
Contributor

@klzns klzns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alcar alcar merged commit de93a7e into master Jun 12, 2019
@alcar alcar deleted the fix/search-context-criteria branch June 12, 2019 14:18
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 12, 2019

Your PR has been merged! App is being published. 🚀
Version 2.80.2 → 2.80.3

brunorodmoreira pushed a commit to brunorodmoreira/store-graphql that referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants