Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [KI 1092989] getOrganizationsByEmail to return only active organizations #184

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

giurigaud
Copy link
Contributor

@giurigaud giurigaud commented Oct 18, 2024

What problem is this solving?

Inactive organizations shown when changing organizations

How to test it?

  • Register at least two organizations with the same email;
  • Inactivate an organization;
  • Enter the store and change the organization; the inactive organization can't be shown in the list.

Workspace

Screenshots or example usage:

Before change:
KI 1092989  Before

After change:
Screenshot 2024-10-18 at 12 23 14

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

Copy link

vtex-io-ci-cd bot commented Oct 18, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 18, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@enzomerca enzomerca requested a review from a team October 22, 2024 16:20
node/typings.d.ts Outdated Show resolved Hide resolved
node/resolvers/Queries/Organizations.ts Show resolved Hide resolved
Copy link

github-actions bot commented Oct 25, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 76, PR deletions = 11

Generated by 🚫 dangerJS against c71525e

graphql/schema.graphql Outdated Show resolved Hide resolved
node/resolvers/Queries/Organizations.ts Outdated Show resolved Hide resolved
node/resolvers/Queries/Organizations.ts Outdated Show resolved Hide resolved
node/resolvers/Queries/Organizations.ts Outdated Show resolved Hide resolved
graphql/schema.graphql Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants