Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout payment #1

Merged
merged 7 commits into from
Feb 13, 2020
Merged

Checkout payment #1

merged 7 commits into from
Feb 13, 2020

Conversation

pedromtec
Copy link
Contributor

@pedromtec pedromtec commented Feb 7, 2020

What problem is this solving?

In this task, I wanna test the communication between the IO app and iframe.

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Feb 7, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 7, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

manifest.json Outdated Show resolved Hide resolved
@mredigonda
Copy link

Currently, accessing the workspace looks like this:

image

I might actually be a problem with permissions, but it's not allowing me to test this.

@@ -4,5 +4,8 @@
"browser": true,
"es6": true,
"jest": true
},
"rules": {
"@typescript-eslint/no-non-null-assertion": "off"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is good reason, I recommend removing this ESlint override

react/Payment.tsx Show resolved Hide resolved
react/Payment.tsx Show resolved Hide resolved
react/Payment.tsx Outdated Show resolved Hide resolved
react/Payment.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@lucasecdb lucasecdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

react/Payment.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jeffersontuc jeffersontuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtex-io-docs-bot
Copy link

Beep boop 🤖 That's ok, I created an issue for this so we don't forget

@pedromtec pedromtec deleted the checkout-payment branch February 13, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants