Checkout payment #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
lucasecdb
suggested changes
Feb 10, 2020
|
Currently, accessing the workspace looks like this:
I might actually be a problem with permissions, but it's not allowing me to test this. |
| @@ -4,5 +4,8 @@ | |||
| "browser": true, | |||
| "es6": true, | |||
| "jest": true | |||
| }, | |||
| "rules": { | |||
| "@typescript-eslint/no-non-null-assertion": "off" | |||
There was a problem hiding this comment.
Unless there is good reason, I recommend removing this ESlint override
lucasecdb
reviewed
Feb 11, 2020
arturpimentel
approved these changes
Feb 13, 2020
marcoskwkm
approved these changes
Feb 13, 2020
|
Beep boop 🤖 That's ok, I created an issue for this so we don't forget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
In this task, I wanna test the communication between the IO app and iframe.
How should this be manually tested?
Workspace
Checklist/Reminders
README.md.CHANGELOG.md.Screenshots or example usage
Type of changes
Notes